Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback of bugs found in the Kaiiju experimental branch #2

Open
xmk2333 opened this issue Jun 14, 2023 · 3 comments
Open

Feedback of bugs found in the Kaiiju experimental branch #2

xmk2333 opened this issue Jun 14, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@xmk2333
Copy link

xmk2333 commented Jun 14, 2023

Is your feature request related to a problem?

Support for more features

Describe the solution you'd like.

can you try merging kaiiju

Describe alternatives you've considered.

1

Other

1

@xmk2333
Copy link
Author

xmk2333 commented Jun 14, 2023

@killerprojecte
Copy link
Owner

I will not merge from any fork other than the official Folia

This is just an experimental branch
Not for vanilla features like Kaiiju

But I can still add a special branch (no promises of any stability and new updates) to experiment with Kaiiju merges. I do this just for fun and I will not be responsible for anyone.

@killerprojecte killerprojecte added the enhancement New feature or request label Jun 17, 2023
@killerprojecte
Copy link
Owner

Download dev build from release

@killerprojecte killerprojecte changed the title merging kaiiju Feedback of bugs found in the Kaiiju experimental branch Jun 17, 2023
killerprojecte pushed a commit that referenced this issue Jul 11, 2023
The end gateway is supposed to teleport the person who threw
the ender pearl.

The changes more closely mirror Vanilla behavior. The current
exceptions to Vanilla behavior are:

1. The first teleportation attempt for the end gateway always fails
2. If the ender pearl thrower is riding a vehicle, the thrower is
   dismounted from their vehicle.

I don't see any solutions for #1 right now. The root issue is that
since the end gateway does not have a target location, it has to
search for one. However, it can _fail_ to find a target location,
in which case the teleportation should not occur. Since the search
must take place asynchronously, it requires the entity to be
removed from the world.

For #2, this is because Vanilla's behavior is broken and does not
correctly teleport players riding boats. We can fix this by simply
dismounting the player and teleporting them separately of their boat,
which seems to be what Vanilla is trying to do given it does _not_
try to teleport the root vehicle of the player.

This is a partial fix to PaperMC#51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants