Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify description of -x option #40

Open
magnumripper opened this issue Aug 16, 2021 · 3 comments
Open

Clarify description of -x option #40

magnumripper opened this issue Aug 16, 2021 · 3 comments
Assignees

Comments

@magnumripper
Copy link
Contributor

I had to look at the source to be sure that in -x offset data, the offset is written in decimal.

While at it, it would be nice if you could say -x 0x100 instead of -x 256, such as using %i with scanf().

@kimci86
Copy link
Owner

kimci86 commented Aug 16, 2021

Hello, thank you for your suggestion.

it would be nice if you could say -x 0x100 instead of -x 256, such as using %i with scanf().

This is already supported. It is a feature of std::stoi when the base argument is 0.
I agree I should document this somewhere.

@kimci86 kimci86 self-assigned this Aug 16, 2021
@cxzstuff
Copy link

cxzstuff commented Nov 7, 2021

BTW, -x -1 XX doesn't work in v.1.3.2. Still worked in v.1.3.1.

@kimci86
Copy link
Owner

kimci86 commented Nov 8, 2021

BTW, -x -1 XX doesn't work in v.1.3.2. Still worked in v.1.3.1.

Nice catch, thank you. (I need to add automated testing.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants