Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve domain names #245

Open
steinerkelvin opened this issue Nov 22, 2022 · 1 comment
Open

Resolve domain names #245

steinerkelvin opened this issue Nov 22, 2022 · 1 comment

Comments

@steinerkelvin
Copy link
Contributor

steinerkelvin commented Nov 22, 2022

Domain names should work as peer arguments and on config file.

This patch on the default config file should work:

diff --git a/kindelia/default.toml b/kindelia/default.toml
index 588a578..d3e439e 100644
--- a/kindelia/default.toml
+++ b/kindelia/default.toml
@@ -6,8 +6,8 @@ network_id = "0xCAFE0006"
 
 [node.networks.0xCAFE0006]
 initial_peers = [
-  "64.227.110.69",
-  "188.166.3.140",
+  "node-ams3.testnet.kindelia.org",
+  "node-sfo3.testnet.kindelia.org",
 ]

Note: we don't have IPv6 support yet.

@steinerkelvin steinerkelvin changed the title Resolve domain names on config file Resolve domain names Nov 22, 2022
@steinerkelvin steinerkelvin moved this from New to Icebox in Kindelia Network Project Nov 22, 2022
@dan-da
Copy link

dan-da commented Nov 23, 2022

yeah, I thought about this a bit. Rust std lib has SocketAddr which supports ip:port. It would be nice to have an enum type that supports [domain|ip]:port and maybe resolves the domain for us. Probably exists in a 3rd party crate somewhere. This is so common I've gotta think it is well solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants