Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#134 Extras are now item-specific #135

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#134 Extras are now item-specific #135

wants to merge 2 commits into from

Conversation

nemaberci
Copy link
Contributor

Closes #134

@nemaberci nemaberci requested a review from Gerviba March 8, 2022 23:21
Gerviba
Gerviba requested changes Mar 10, 2022
View reviewed changes
Copy link
Member

@Gerviba Gerviba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still does not support history.

src/main/kotlin/hu/kirdev/schpincer/model/ExtraEntity.kt Outdated
var price: Int) {

@ManyToOne
lateinit var item: ItemEntity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use JoinColumn
  • Provide default value (required for live db migration)

src/main/kotlin/hu/kirdev/schpincer/model/ExtraEntity.kt Outdated
@ManyToOne
var circle: CircleEntity,
@ManyToOne
var circle: CircleEntity,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we store the circle id here?

src/main/kotlin/hu/kirdev/schpincer/service/ExtrasService.kt Outdated
mappedExtra.name,
CustomComponentType.valueOf(mappedExtra.type),
i
)
optionalExtra.ifPresentOrElse({
it.price = mappedExtra.prices[i]
extrasRepository.save(it)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the display name here.

@nemaberci nemaberci requested a review from Gerviba March 16, 2022 10:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerviba Gerviba Awaiting requested review from Gerviba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New order insight popup bug
3 participants
@nemaberci @Gerviba @kovacsbertalan