Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty .svg worfklow file, if workflow saved without changes #6290

Open
gerlingsm opened this issue Nov 5, 2024 · 0 comments · May be fixed by #6294
Open

Empty .svg worfklow file, if workflow saved without changes #6290

gerlingsm opened this issue Nov 5, 2024 · 0 comments · May be fixed by #6294
Labels
bug workflow workflow editor and configuration

Comments

@gerlingsm
Copy link
Contributor

Describe the bug
If an existing workflow is opened for editing via Kitodo and then saved again without making any changes to it, the corresponding workflow .svg will end up being 0 bytes in size and therefore empty/broken.
This only affects the svg image file, the workflow itself remains unchanged. (The file is only rewritten, which can be recognised by the modification date of the file)

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Project' --> 'Workflows'
  2. Open an existing workflow
  3. Do NOT make any changes to the workflow and save it
  4. Workflow is saved without an error message
  5. Determine that the associated .svg file is empty / 0 bytes in size
    1. Apart from the filesystem, you will also notice this in the corresponding process template when you unfold it

Expected behavior
Saving workflow without changes should also result in a functioning .svg file

Workaround

  1. Open the Workflow
  2. CHANGE anything in the workflow (for example remove and readd "end")
  3. Save the workflow
  4. A new correct svg file should be generated

Screenshots

Release
Tested with 3.7.1

Desktop (please complete the following information):

  • OS: Kubuntu 22.04
  • Browser Firefox
  • Version 132.0 (64-bit)
@gerlingsm gerlingsm added the bug label Nov 5, 2024
@solth solth added the workflow workflow editor and configuration label Nov 5, 2024
@BartChris BartChris linked a pull request Nov 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug workflow workflow editor and configuration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants