-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spawnpoints bug #24
Comments
That's really odd... |
This error keeps happening. Using Multiverse-core as a multiworld support plugin. |
I can't repeat this... |
It does not happen every time, you restart. Eventually, you or someone else will discover this too and, maybe then you will know, how to fix it, but I hope, that problem will not happen again. |
I am having this problem. My server runs Multiverse with almost 30 worlds. Everything is properly configured. If I fix the configs and reload, it fixes it temporarily. But this issue persists, and occurs again eventually. I do believe it may have to do with restarts, but then again it may also be due to Multiverse Adventure, which is also enabled on the Hunger Games world. I will post more if I find out more info. Another thing, only SOME of the spawns were changed. They were changed to be the same world I was in when I initiated the /hg join command, which at the time was our default bukkit world, and our server spawn. I have not tested it in other worlds yet. |
I restarted my server, and the following variables changed.
|
Hmm...this is really odd... |
I have confirmed that this has changed without me restarting the server, today. So, this error does not need a server restart to occur. However, I also restarted it tonight and it occurred once again. I can solve this by editing the config file via ftp, changing the world names, then proceeding to /hga reload. I see you've had trouble replicating this error. Here is some additional information about my server and how it is set up. We're running the latest, 1.3.2 R-2.0 Bukkit stable release. Our host is running our server on MultiCraft, and we have a dedicated IP set up for it. Our dns is smp.kingdomofartania.com, and our website is http://www.kingdomofartania.com I am running the following plugins: The plugins I think MAY affect this or be affected by it: There are no visible errors that would relate to anything that may cause this to happen. It's just a config change that happens automatically. |
I just did a restart this morning, two of them actually, for a plugin install. No changes were made to the MyHungerGames plugin config. So its not the server restart event that causes it. It's more than likely because some other plugin is conflicting, may be one of the ones I mentioned above. If this issue happens again, I'll post my config data for it. It's enough to say that this issue was 100% definitely happening with default config settings, and it happened once or twice after I made some alterations to the config. |
I installed it this morning. Copied the old config.yml and games.yml once I made sure nothing changed, restarted the server, it changed the arena names on me. It did this for 3 restarts until I used the /hga reload command in-game (after changing the games.yml via ftp). I will let you know if this issue happens again, and I'll post my configs then if it does. |
After running it for a little bit, can you post your myhungergames.log |
games: |
Oct 22, 2012 8:53:11 AM com.randude14.hungergames.Logging log |
It changed the first spawnpoint location so far, I was the only one to try and join it, as you can see, I have a feeling it may try to change others if multiple people tried to join. The log also shows my multiple restarts and stuff. Last time I left it, the config had pvp_hungergames for every world mentioned in games.yml. now it shows s_main (our main default bukkit spawn) for the first spawnpoint. |
Can you manually reset the config and delete myhungergames.log. I'd like to see a before and after. |
All those were brand new, I did a fresh install. Each of the restarts in the log above, was after the fresh install, each time I had to manually reset the config. I can do it again, but it'll show the same stuff. I'll manually reset and delete the log now and send you another set of data tomorrow. |
Oct 24, 2012 8:40:59 AM com.randude14.hungergames.Logging log |
My config also, this morning: games: |
That info is dated Oct 28, at 9:40 AM EST. It's been quite a few days since I have manually reset the config so there's a bit of info. But as we can see here, it's set one of the spawns back to s_main. My server traffic has died down a lot since 1.4.2 release, we're still running 1.3.2 and will be until craftbukkit and our plugins have a stable, recommended build. P.S. - Is there any part of the code that looks at the default bukkit world for the server in server properties?? I can see that possibly messing things up, as our hunger games world is just a multiverse world and its not our default world. |
No, there is no ode that looks for the default world. This issue is super strange, because it saves it by name and parses it by name. I thought it might be parsing it that causes the problem. These logs show otherwise. That means that saving to the games.yml is causing a problem. |
Sounds like a good theory. Just wondering how things are coming along with this bug, I've noticed there have been a few other people with similar issues. |
Does this still happen? |
I wouldn't know, we stopped using the plugin months ago because of it :( |
I would try again. This bug was never really confirmed (doesn't mean it didn't exist), so there's a high likelihood it happened because of a bukkit error and is not the fault of MyHungerGames. |
Honestly I think it had something to do with Multiverse. When Bukkit BETA 1.5 comes out and everything is updated (we're at 1.4.7 and behind on plugin updates right now) I will see about possibly testing this again. |
Just got Bukkit BETA 1.5. Making sure everything is stable, and I'll look into testing this within the next week or two. |
I was just wondering if this bug still exists, because we had couple of troubles like this when testing the plugin. Or is there any workaround to avoid this bug? Ilike the plugin really, but with this bug it's not useful. I'm currently running the latest recommended bukkit server (1.5.2) with the latest version of this plugin. In addition to that I'm using following plugins: Multiverse, Multiverse-Adventure, WorldEdit I was also confused about the Multiverse-Adventure implementation, there was some weird code that gave no sense which I deleted. (#58) |
I believe it does still exist. I have not tested it as we removed the plugin. It's not something we want for our server anymore and was too problematic. |
Yes it is very problematic if this still exist, but I can't find any other plugin that supports full world rollback/reset or works faultless with the Multiverse-Adventure plugin. I was also wondering about removing or blocking the save to the conifguration, if it's a problem with the save method. I don't need to save the configuration when a game ends, honestly I don't even know why this is important. |
That doesn't make sense. I do not have a machine that is setup for java development or I'd probably try the same thing, that "save configuration" at the end is not something that makes sense. How about this, do you have the HG world set to stay in memory even if there is nobody in it? (multiverse core setting). Maybe this is causing problems with the HG plugin. Just trying to think out of the box here, I'll admit I have not used or tested the plugin in a while. I would set it so the world stays in memory. (while in world, type /mvm set memory true) |
For those of you getting this bug, what world manager are you using? What build of MyHungerGames? |
As I said, I'm using Multiverse for world management and the latest compiled MyHungerGames from github. Do you think it's possible to add a workaround for this bug? Like setting all spawns to the correct world before a player wants to join or something like that. That wouldn't save the spawns correctly, I know, but it would help the players spawn at the correct spawnpoints. |
I was able to fix this bug with manually changing the world of the spawnpoint to the correct one. It's more a workaround than a fix like I said above. Maybe kitskub can implement this workaround so all of you guys having this problem are free of this bug. |
Unfortunately, there is no definitive way, in code, to tell where you WANT the spawnpoints to be. What version of multiverse are you guys using? |
There is a way to manipulate the locations. You can set the world of the location at the end of getNextOpenSpawnPoint (before returning, that should be clear). I already tested that, it works pretty good. I also think I know where the problem comes from. It only appears when using Multiverse-Adventure. Ok here's what I think is happening: One possible fix for that would be to let the server wait for Multiverse-Adventure to load the world correctly. When it's finished the server could continue with loading the spawnpoints. |
When first creating a tournament with lots of spawnpoints (I had 24), everything is fine, but after restarting a server, or a tournament, I can't tell for sure, but I think, after stopping a tournament or reloading the plugin, spawnpoints coordinates stay the same, but some of them changing their world. When they were originally placed in World2, after a restart, some of them starting to belong to World1.
So, it looked like this:
games:
Tournament:
spawn-points:
spawnpoint1: 158.5 71 242.5 0 0 World2
spawnpoint2: 122.5 71 242.5 0 0 World2
spawnpoint3: 140.5 71 224.5 0 0 World2
spawnpoint4: 140.5 71 260.5 0 0 World2
spawnpoint5: 127.5 71 229.5 0 0 World2
spawnpoint6: 153.5 71 255.5 0 0 World2
but after restart, it looks like this:
games:
Tournament:
spawn-points:
spawnpoint1: 158.5 71 242.5 0 0 World2
spawnpoint2: 122.5 71 242.5 0 0 World1
spawnpoint3: 140.5 71 224.5 0 0 World2
spawnpoint4: 140.5 71 260.5 0 0 World1
spawnpoint5: 127.5 71 229.5 0 0 World1
spawnpoint6: 153.5 71 255.5 0 0 World2
The text was updated successfully, but these errors were encountered: