Consider adding a helper method in KiwiResources to buffer entity and do fromResponse

[sleberknight]

See this gist for code examples.

Whenever you create a Response from the response of another request, i.e. Response.fromResponse(response).build(), according to the Response Javadocs you must call bufferEntity first if the entity from the original response is unconsumed.

This is one of those things that's really easy to forget about, so maybe we should create a method in KiwiResources that does these things for us, e.g. instead of:

// inside a Jakarta RS resource endpoint
var response = makeCallToOtherService();

response.bufferEntity();
return Response.fromResponse(response).build();

we could do:

// inside a Jakarta RS resource endpoint
var response = makeCallToOtherService();

return KiwiResources.fromResponseBufferingEntity(response).build();

The fromResponseBufferingEntity would basically do:

public static fromResponseBufferingEntity(Response originalResponse) {
    originalResponse.bufferEntity();
   return Response.fromResponse(originalResponse);
}

[sleberknight]

For historical reasons, we have several utility classes related to JAX-RS (now Jakarta RS) responses. Roughly, the use cases are:

Class	Main use case
KiwiResources	Contains utilities mainly intended to be used inside JAX-RS/Jakarta resource classes for verifying entities (e.g. obtained from a service or data access class), factories for creating new responses, and utilities for validating query parameters.
KiwiResponses	Utilities to determine whether responses are successful or not, and to perform actions based on success or failure. We use these most often in classes that make HTTP requests.
KiwiStandardResponses	A set of "standard" (i.e. opinionated) response factory methods for HTTP methods. These are used inside JAX-RS/Jakarta RS resource classes.

[sleberknight]

The above was also used to enhance the javadocs of these classes in #589 and is the reason this new method should live in KiwiResources