Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not open articles with special characters #760

Closed
Popolechien opened this issue Jun 11, 2018 · 8 comments
Closed

Does not open articles with special characters #760

Popolechien opened this issue Jun 11, 2018 · 8 comments
Assignees
Labels
Milestone

Comments

@Popolechien
Copy link
Member

Popolechien commented Jun 11, 2018

Tested on Wikivoyage Europe (latest zim 2018-06-10) and Kiwix-Android 2.4 Build 1180980:

When searching for an article I can not open those with special characters (Saint-Lô, Zürich, Korčula): they are found in search, even without typing ô, ü or č, but clicking/tapping the name in the search list will return to the previously opened article.

@Popolechien Popolechien added this to the 2.4 milestone Jun 11, 2018
@kelson42 kelson42 self-assigned this Jun 11, 2018
@kelson42
Copy link
Collaborator

@mhutti1 I confirm this regression with http://mirror.download.kiwix.org/zim/wikivoyage/wikivoyage_en_europe_2018-06.zim :(

@kelson42 kelson42 assigned mhutti1 and unassigned kelson42 Jun 12, 2018
@mhutti1
Copy link
Contributor

mhutti1 commented Jun 17, 2018

Seems to be related to #594

@mhutti1
Copy link
Contributor

mhutti1 commented Jun 18, 2018

Root cause is #765 but I am going to implement a quick fix here.

@mhutti1
Copy link
Contributor

mhutti1 commented Jun 18, 2018

Done some research and I think implementing #765 is necessary to catch all possible versions of this but will require database changes and upgrade.

@Popolechien
Copy link
Member Author

Ok FWIW it doesn't work with Chinese characters either.

@kelson42
Copy link
Collaborator

@mhutti1 I do not think you have do to so because (1) This was working fine, we have a regression here (2) kiwix-serve works that way too, and it works fine

@mhutti1
Copy link
Contributor

mhutti1 commented Jun 20, 2018

@kelson42 Ok I have come up with a fix that should work but we should implement #765 for 3.0

@kelson42
Copy link
Collaborator

@mhutti1 thx, yes we should use urls instead of titles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants