-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout while compiling kiwix-build on my system #354
Comments
@Aditya-Sood, what is your system ? |
@Aditya-Sood Without feedback from you on this ticket we won't be able to help you and I will have to close the ticket. |
@mgautierfr sorry for not responding here! I didn't know you had created a separate issue for this, I've been replying on the previous one for the last couple of days @kelson42 I have wiped the previous local kiwix-build repo and started over. Things are okay as of now, the I'll update by evening of the progress |
@mgautierfr do I need to build kiwix-lib before I put it in the SOURCE directory of kiwix-build for building?
|
@Aditya-Sood Delete SOURCE and all BUILD_ directories and try again? |
If I delete SOURCE then won't it use the kiwix-lib it clones from github? |
Ok what is the difference between the two? |
Basically my local repo has the changes for issue 765 that I want to test |
Well then your changes must have cause it?... Can you debug what might have happened? |
@mhutti1 so I deleted all the
I was getting this error last time as well before I started over with a fresh clone. So I guess I need to build the local kiwix-lib repo (with changes for issue 765) before copying it into kiwix-build's SOURCE directory? |
No... There should not be any build files in SOURCE, it is literally just source code. I would imagine that that error is because you need to rebase your changes ontop of kiwix-lib master. Once you do this then the file it is complaining about will exist. |
So just |
Yes
…On Sun, 18 Aug 2019, 10:44 Aditya-Sood, ***@***.***> wrote:
So just git rebase master and then copy the local repo into SOURCE?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#354?email_source=notifications&email_token=AAROKWMQCH5F7LL2QIMMVSDQFEKWPA5CNFSM4IH2D2YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4Q4KQA#issuecomment-522306880>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAROKWMBMEHYE27UQZRWCDTQFEKWPANCNFSM4IH2D2YA>
.
|
The build completed successfully after the rebase |
I'm having trouble getting the JNIKiwixReader updated. Even after commenting out the previous implementations that I could find, the reader somehow still uses the previous implementation. (I've kept the kiwix-lib .aar file in app/libs) EDIT: I merged develop again and manually deleted the kiwix-android/kiwixlib directory |
@Aditya-Sood You may need to restart and invalidate your cache. Other than that just check your build.gradle. The kiwixlib dependency is there pretty clearly so it should be trivial to see what it is trying to load. |
Invalidating caches didn't help earlier EDIT: Importing the project again removed the error but is still not updating the JNIKiwixReader |
@Aditya-Sood Can you share your build.gradle? |
build.gradle - I haven't made any changes to it though |
I'm getting a As a side note: Could you have a look at my kiwix-lib .aar file once? There are a couple of empty directories in it, which doesn't make sense to me. |
Is this |
It's used in the shouldUseLocalVersion() function in build.gradle |
Can you give it an absolute path and try that? |
I figured out the problem with the .aar - basically kiwix-build uses the master branch of the kiwix-lib source code when building. Merging my changes into the master branch did the trick, the updated method is shown in JNIKiwixReader now. I'll get to testing now |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
@Aditya-Sood Do you still have this issue? |
@kelson42 it's been fixed, I'd made a mistake somewhere during setup. Repeating the setup afresh had fixed it. |
[This issue has been reported at #346 by @Aditya-Sood, but as the thread has move to another discussion, I prefer to move the "timeout" problem in another issue]
I'm working on fixing kiwix/kiwix-android/#765 for which I had to compile kiwix-lib into the app, which I was told required using kiwix-build
During setup, upon running
kiwix-build kiwix-lib -v
, I obtained the following output:The entire output of the command is here
There was a
test libzim : run command 'meson test --verbose -t 8'
line in the middle of that output, running which gave this error:I'm guessing this is related to the timeout bit in #188
I am basically looking for a way to test the changes I have made to kiwix-lib (commit) & kiwix-android (commit)
Any help is much appreciated!
The text was updated successfully, but these errors were encountered: