Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: refactor secpk1 recover to not use low level endianness #708

Open
Eikix opened this issue Feb 7, 2025 · 0 comments
Open

dev: refactor secpk1 recover to not use low level endianness #708

Eikix opened this issue Feb 7, 2025 · 0 comments
Milestone
EELS migration

Comments

@Eikix
Copy link
Member

Eikix commented Feb 7, 2025

why

we want to encapsulate endianness in utils

what

refactor secpk1_recover_big_ends to use type conversions U256_to_bytes_be or le

how

  • in secp256k1_recover_uint256_bigends, remove endianness assumption and return Hash32 type for x and y
  • in public_key_point_to_eth_address_be, use keccak little endian
  • refrain from using low level utils to reverse endianness of a word in the codebase, encapsulate these assumptions in test utils
@github-project-automation github-project-automation bot moved this to Backlog in Keth Feb 7, 2025
@Eikix Eikix moved this from Backlog to Todo in Keth Feb 10, 2025
@Eikix Eikix added this to the EELS migration milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Keth
Status: Todo
Milestone
EELS migration
Development

No branches or pull requests
1 participant
@Eikix