Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow media files to be non-ASCII and not force unique name with a suffix #2277

Open
veesiom opened this issue Jan 30, 2025 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@veesiom
Copy link

veesiom commented Jan 30, 2025

Is your feature request related to a problem? Please describe.
As far as i can see, media filenames hardcoded to be:

  • unique (with random suffix)
  • ASCII only.

Describe the solution you'd like
Why wouldn't the app instead of adding random suffix just throw an error like there's already a file by that name, so user can come up with another unique, but quite readable filename?
Also, why wouldn't it support any other characters and not only the ASCII symbols? So you can name your attachments on any different languages.

We would really like to see any way around this as we've planned to use this great tool to send messages to our customers.

@veesiom veesiom added the enhancement New feature or request label Jan 30, 2025
@veesiom veesiom changed the title Some hardcoded stuff with Media uploads Allow media files to be non-ASCII and not force unique name with a suffix Jan 30, 2025
@knadh
Copy link
Owner

knadh commented Jan 30, 2025

Hi @veesiom.

  1. Not enforcing unique filenames is a convention in many content management systems. It's very common to just have a "header.png" for every newsletter rather than forcing the user to locally make it "header1", "header2" etc.

  2. The ASCII bit is an oversight. I can't recollect why it was enforced in the early days, perhaps there were smtp/lib compatibility issues. Will remove this and add unicode support in the next version.

@knadh knadh self-assigned this Jan 30, 2025
@veesiom
Copy link
Author

veesiom commented Jan 30, 2025

Hi @knadh , thanks for the quick reply!

I didn't quite get your point about unique file names. That's what I'm talking about, isn't it? You can't just upload your media as header.png, as it becomes header_A7hdas.png after the upload. Can you expand on that a bit?

Regarding ASCII, that's great to hear! I'm looking forward to the next release then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants