Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create JS-only version #19

Open
tinok opened this issue Nov 13, 2018 · 3 comments
Open

Create JS-only version #19

tinok opened this issue Nov 13, 2018 · 3 comments

Comments

@tinok
Copy link
Member

tinok commented Nov 13, 2018

Ideally, kobomaps should use only JavaScript and HTML, without any PHP.

The various maps could then be hosted on S3 and get updated whenever there is a new commit to master.

PHP was used initially to allow embedding the map in a Drupal environment, but that is not the best solution long-term.

@tinok
Copy link
Member Author

tinok commented Nov 15, 2018

@nstraub I have created two maps that don't require PHP in the peacebuildingdata branch. This required making two small changes in the data_visualize.js file. The index.html file pulls together mapheader.php, mapcontent.php, config.php, and index.php.

It would be nicer to continue using templates for mapcontent and mapheader so updating each map isn't a hassle in the future.

@nstraub
Copy link
Contributor

nstraub commented Dec 24, 2018

@tinok the rewrite branch doesn't depend on PHP at all, maybe after the festivities are over we could discuss merging it into master or peacebuildingdata

@tinok
Copy link
Member Author

tinok commented May 13, 2019

I saw your recent changes @nstraub ... should we consider merging it into the main branches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants