Replies: 7 comments 8 replies
-
What are we on right now?
It may depend on the reward of the issue (small bounty, small reward) |
Beta Was this translation helpful? Give feedback.
-
this ☝️ |
Beta Was this translation helpful? Give feedback.
-
Moved from round-robin to load balance.
Because you want to rotate between sub-set of folks in a group to everyone grant equal choice have exposure to particular code and save willpower on other things, where algo can take care of this. I mean, if the wrong member is assigned, I've noticed in some cases (<20%) adding someone extra helped or the original reviewer calls someone else. |
Beta Was this translation helpful? Give feedback.
-
Yet it would require writing some system for it to establish. @petersopko been sharing numbers from PRs review activty tho, so it's time to discuss it :) |
Beta Was this translation helpful? Give feedback.
-
|
these are the current numbers when it comes to reviews, {
"roiLeo": {
"prReviewCount": 217,
"prReviewInteractionCount": 390
},
"vikiival": {
"prReviewCount": 194,
"prReviewInteractionCount": 336
},
"kkukelka": {
"prReviewCount": 47,
"prReviewInteractionCount": 58
},
"yangwao": {
"prReviewCount": 33,
"prReviewInteractionCount": 40
},
"prachi00": {
"prReviewCount": 21,
"prReviewInteractionCount": 25
},
"petersopko": {
"prReviewCount": 19,
"prReviewInteractionCount": 22
},
"Jarsen136": {
"prReviewCount": 1,
"prReviewInteractionCount": 1
},
"KngZhi": {
"prReviewCount": 1,
"prReviewInteractionCount": 1
},
"marsic3": {
"prReviewCount": 1,
"prReviewInteractionCount": 2
},
"dezine2dev": {
"prReviewCount": 1,
"prReviewInteractionCount": 1
}
}
|
Beta Was this translation helpful? Give feedback.
-
|
damn, @roiLeo is a beast 💪 |
Beta Was this translation helpful? Give feedback.
-
|
Any updates in this regard? Would be a helpful incentive for some of us, as I currently only have tome to review some PRs throughout the day. |
Beta Was this translation helpful? Give feedback.
-
|
updated table |
Beta Was this translation helpful? Give feedback.
-
can we have numbers since this date @petersopko ? |
Beta Was this translation helpful? Give feedback.
-
|
here are the updated numbers, closed/merged PRs reviewed >= 2022-04-04 (where author of PR isn't reviewer) {
"roiLeo": {
"prReviewCount": 53,
"prReviewInteractionCount": 113
},
"vikiival": {
"prReviewCount": 46,
"prReviewInteractionCount": 97
},
"kkukelka": {
"prReviewCount": 37,
"prReviewInteractionCount": 45
},
"prachi00": {
"prReviewCount": 22,
"prReviewInteractionCount": 26
},
"petersopko": {
"prReviewCount": 19,
"prReviewInteractionCount": 22
},
"KngZhi": {
"prReviewCount": 1,
"prReviewInteractionCount": 1
},
"Jarsen136": {
"prReviewCount": 1,
"prReviewInteractionCount": 1
},
"yangwao": {
"prReviewCount": 1,
"prReviewInteractionCount": 1
}
} |
Beta Was this translation helpful? Give feedback.
-
|
I'm thinking aloud about drafting the first proposal till we "deploy" the right system to keep things going as we have a quite loaded roadmap. As usual, it's the first shot, so feel free to have objections, I also don't want to introduce wrong metrics, it's all about experimenting here and rewarding for your long-term participation. I guess let's take roiLeo as an example. Assigned 53 PRs and 113 interactions (comments, code reviews (?), &c). If we go averaging as some PRs might be super light, where you spent less than 20 minutes, at some might hit up to an hour, going with $30 accounting for context switching should be a sweet deal. The formula could be Till we figure out a better system, we can think of making it on some n-weeks basis, like 4~8-weeks The brief calculation in particular order would be Noting down addresses in a particular order, took them from your last payout PRs, I'll proceed with payouts soon
For the future, seems @Jarsen136 would be eligible to help us in the code review guild if you would want to! :) |
Beta Was this translation helpful? Give feedback.
-
|
Yes @Jarsen136 really provided so much value to the project in the past months. As he has acquired a pretty good understanding of the repository it would be great to have him onboard in the guild! |
Beta Was this translation helpful? Give feedback.
-
|
Thank you, guys! I am willing to join in code review guild. 😄 |
Beta Was this translation helpful? Give feedback.
-
|
Let's accept invite and welcome 🙌 😄 |
Beta Was this translation helpful? Give feedback.
-
|
Sent $7128 in $KSM, enjoy! :) |
Beta Was this translation helpful? Give feedback.
-
Hey, I guess @kodadot/code-review-guild doing a vital part of our way to push stuff to production on the scale to distribute load off one's head, back then me & @vikiival and adding quality for code reviews and limit the damage.
As we value your time and attention, we are looking for ways to put the right rewards and incentives to sustainably help us grow the codebase.
Yet briefly chatted w @petersopko we will try to drive some numbers from PRs actions by code reviewers as my earliest promise to figure out these things what's would be the best fit-out.
Current numbers, we had running Code Review Guild since approx 2022/04/04, which resulted in 102 merged PRs.
The early set of folks was 4, so that's approx 25.5 as we've been using round robin and not load balance, it's just average for the easiest approximation.
Right now are thinking of rewarding $500-$1k, which could be in the range of $20-$40 per code review.
Yet this has some bonkers. If the pull request is not complex it doesn't make much sense upper bound, hence when the issue is complex and even then code review is made and some bug appeared afterwards, which doesn't fix all things.
Namely participants
Ref
Beta Was this translation helpful? Give feedback.
All reactions