Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook and missing custom header after a restore #107

Closed
Bruneau-Pierre opened this issue Dec 2, 2024 · 5 comments
Closed

Webhook and missing custom header after a restore #107

Bruneau-Pierre opened this issue Dec 2, 2024 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs https://up-for-grabs.net/

Comments

@Bruneau-Pierre
Copy link

Brief bug description

After a backup / restore operation, the custom headers are missing.
I check the webhook backup file, the custom headers are present. It seems to be are restore issue.

Repro steps

Generate a backup after adding custom header to the webhook.
Restore this backup.

Expected behavior

To have the custom header restored.

Test environment

Node.js & data-ops npn 2.2.2 package.

Additional context

Add any other context about the problem here.

I'm speaking about these custom headers :

image

@IvanKiral IvanKiral added bug Something isn't working good first issue Good for newcomers up-for-grabs https://up-for-grabs.net/ labels Dec 4, 2024
@IvanKiral
Copy link
Contributor

Thanks for the issue, it seems that there is a missing property for custom headers in the code indeed. I will have a look :)

@Bruneau-Pierre
Copy link
Author

Thank you very much for your quick answer !

@IvanKiral
Copy link
Contributor

IvanKiral commented Dec 6, 2024

I created a PR. Can you test it out, whether it works now okay? #108.

You would need to clone the repository, checkout to the branch fix_webhooks_headers and run data-ops locally

@Bruneau-Pierre
Copy link
Author

I just test and it's working very well.
Thank you very much !

@IvanKiral
Copy link
Contributor

merged in #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs https://up-for-grabs.net/
Projects
None yet
Development

No branches or pull requests

2 participants