-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A2S_INFO Will be changed by Valve soon #331
Comments
Thanks for the heads-up. Development has been pretty dormant in the recent years, but this some kind of change I‘ll really try to implement in a timely fashion. |
I‘m planning to bring this to both the “current” development version and the 1.3.x branches. |
For compatibility with security patches to future game servers versions this adds a 1200 byte padding to all requests packets as defined in the following HLDS mailing list post: https://www.mail-archive.com/[email protected]/msg01194.html See koraktor/steam-condenser#331
For compatibility with security patches to future game servers versions this adds a 1200 byte padding to all requests packets as defined in the following HLDS mailing list post: https://www.mail-archive.com/[email protected]/msg01194.html See koraktor/steam-condenser#331
@BrutalCSkakan I already added patches to the Java repository. Please feel free to test. |
For compatibility with security patches to future game servers versions this adds a 1200 byte padding to all requests packets as defined in the following HLDS mailing list post: https://www.mail-archive.com/[email protected]/msg01194.html See koraktor/steam-condenser#331
For compatibility with security patches to future game servers versions this adds a 1200 byte padding to all requests packets as defined in the following HLDS mailing list post: https://www.mail-archive.com/[email protected]/msg01194.html See koraktor/steam-condenser#331
For compatibility with security patches to future game servers versions this adds a 1200 byte padding to all requests packets as defined in the following HLDS mailing list post: https://www.mail-archive.com/[email protected]/msg01194.html See koraktor/steam-condenser#331
For compatibility with security patches to future game servers versions this adds a 1200 byte padding to all requests packets as defined in the following HLDS mailing list post: https://www.mail-archive.com/[email protected]/msg01194.html See koraktor/steam-condenser#331
Hello! I will test the Java version as soon as I can. A steam client beta has been released: https://steamcommunity.com/groups/SteamClientBeta/announcements/detail/2896341257765264787 It understands how to respond if the server issues a challenge in response to an A2S_INFO request. Importantly because of the existing filtering environment servers run in, the client will behave EXACTLY as it did before, until the server replies in the new method. (https://twitter.com/ZPostFacto/status/1334700095221104640) The protocol is now as follows: · Client will send the exact A2S_INFO packet that it has always sent, no more, no less. · A new server will reply with a challenge, using the same S2C_CHALLENGE packet that’s used for the A2S_PLAYERS and A2S_RULES packets. (Indeed, if a client is quick enough, it can use the same challenge for multiple requests.) · Now, a client will send a A2S_INFO with the challenge appended. Also: DO NOT ASSUME THAT ANY EXTRA BYTES AFTER THE CHALLENGE ARE INVALID. This is reserved for future expansion to the protocol! There are some more protocol changes in development right now designed to have the client obtain more information from the master server, thus reducing the amount of information that must come from the server. Those improvements won’t be possible if assumptions are made about packet sizes! I’ll post again when there are server binaries available that can opt into the new behavior, fixing the reflection attack vulnerability. You will not want to opt in until all clients you care about are speaking the new protocol. For steam clients, that will probably at least a couple of weeks. |
Hey, just wondering if you were able to add this to the java code and release it? The change from Valve went out yesterday and as expected this is breaking functionality. Would be hugely appreciated if you would be able to release a new version with the fix. :) |
If you're not ready to release these changes on maven, could you explain how I could go about compiling/using the beta code in a project that currently utilizes the released maven version? @koraktor @BrutalCSkakan |
Hello! |
Did you test the Java patch mentioned earlier? |
It looks like I get data, and my system is working as before. |
And I take it back once again, I wasn't aware that the change was on a seperate branch. I am not receiving any errors now. This could probably be pushed to master. |
For compatibility with security patches to future game servers versions this adds a 1200 byte padding to all requests packets as defined in the following HLDS mailing list post: https://www.mail-archive.com/[email protected]/msg01194.html See koraktor/steam-condenser#331
Has this been pushed to master yet? |
For Java, didn’t had time to test the other implementations. The code is available in the |
Seems like @BrutalCSkakan tested it successfully and the current version is broken anyway. Probably safe to just push it? |
Anyone able to do this? |
Not works on cs2, i only receive hostname |
https://steamcommunity.com/discussions/forum/14/2989789048633291344/
Could you get this change ready?
We are depending on this lib (the Java version), so we hope that you or someone else with the knowledge could do the appropriate changes for this.
The text was updated successfully, but these errors were encountered: