Issue after changing the orientation

[blacelle]

I have an issue with UrlImageViewHelper after changing the orientation: the image are resized with an unexpected size.

I believe it is due to the fact you cache mMetrics with the DisplayMetrics associated to the orientation of the first call. It then lead to issues when using mMetrics.widthPixels since it may not be valid anymore after a change of orientation.

1.0.4

[jvmvirus]

I think your code should change to:
final int tw;
final int th;
if (mMetrics == null)
prepareResources(context);
tw = imageView.getWidth() > 0 ? imageView.getWidth() : mMetrics.widthPixels;
th = imageView.getHeight() > 0 ? imageView.getHeight() : mMetrics.heightPixels;
In method setUrlDrawable, it is more generalize.
Thanks and regards,

[blacelle]

I've fixed the issue by keeping 2 sets of mMetrics and mResources, each of them initialized depending on current orientation (Portrait or Landscape)

[koush]

Maybe the fix is to not cache mmetrics and always grab the metrics from imageview that was passed in, if available. Can you submit that?

[koush]

Also, you may want to check out ion:

https://github.com/koush/ion