Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Store third-party identifiers #249

Open
FoxxMD opened this issue Sep 26, 2023 · 5 comments · May be fixed by #361
Open

[Feature Request] Store third-party identifiers #249

FoxxMD opened this issue Sep 26, 2023 · 5 comments · May be fixed by #361

Comments

@FoxxMD
Copy link
Contributor

FoxxMD commented Sep 26, 2023

Implement storage of 3rd party IDs for tracks, artists, and albums. Common IDs:

Benefits of storage:

  • Makes album/artist artwork lookup require less api calls
  • Can serve "external links" for spotify directly instead of using search
  • Enables easier duplicate detection
  • Enables easier re-parsing and metadata lookup in the future

The IDs could be stored on a new table that is a simple KV store with a FK/discriminator for the entity it is associated with. The ID should be able to be submitted alongside a new scrobble (free lookup!) since some scrobble clients can do this. Additionally, it should be able to be edited/updated through an API endpoint.
@nemethf
Copy link

nemethf commented Sep 26, 2023

Since commit 1eaba88, maloja saves various MBID tags

@FoxxMD
Copy link
Contributor Author

FoxxMD commented Sep 26, 2023 •
edited
Loading

say whaaat. It looks like this is just for the listenbrainz endpoint, however. The native endpoint does not store extra fields and the scrobbles endpoint does not display them.

@duckfromdiscord
Copy link
Contributor

We could add something like extrafields 1eaba88#diff-ec004ea2624df9dbf01f0e52f82d9c78355e56aa9a3a0dd73f372ed4c10f0d77R70 to the maloja api? Assuming self.scrobble stores those **extrafields?

@duckfromdiscord duckfromdiscord mentioned this issue Oct 23, 2023
Closed
@duckfromdiscord
Copy link
Contributor

Would be cool to store spotify data too for cases like mine where I scrobble from spotify but have not used it to gather album art data yet and would like to later on

@duckfromdiscord duckfromdiscord linked a pull request May 23, 2024 that will close this issue
Draft
@duckfromdiscord
Copy link
Contributor

#361 would fix this issue

@duckfromdiscord duckfromdiscord mentioned this issue Oct 2, 2024
Closed
@duckfromdiscord duckfromdiscord mentioned this issue Oct 17, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add third-party identifiers duckfromdiscord/maloja
3 participants
@nemethf @FoxxMD @duckfromdiscord