From 30f27f4e253f4145b930cae11b04ef3a3b127cd2 Mon Sep 17 00:00:00 2001 From: Sibasish Behera Date: Tue, 14 Feb 2023 11:44:42 +0530 Subject: [PATCH] Fix: linting issues in checks package Signed-off-by: Sibasish Behera --- checks/updates.go | 8 ++++++++ utils/portforward.go | 1 + version/version.go | 1 + 3 files changed, 10 insertions(+) diff --git a/checks/updates.go b/checks/updates.go index b1c7b796..75e1ebcb 100644 --- a/checks/updates.go +++ b/checks/updates.go @@ -1,3 +1,4 @@ +// Package checks provides utility for checks in karmor CLI tool package checks import ( @@ -9,10 +10,12 @@ import ( "strings" ) +// UpdateChecker structure type UpdateChecker struct { Client *github.Client } +// Fetches all the releases from kubearmor-client repository func (c *UpdateChecker) FetchReleases() ([]*github.RepositoryRelease, error) { releases, _, err := c.Client.Repositories.ListReleases(context.Background(), "kubearmor", @@ -28,6 +31,7 @@ func (c *UpdateChecker) FetchReleases() ([]*github.RepositoryRelease, error) { return releases, nil } +// Gets the mandatory latest release func (c *UpdateChecker) GetLatestMandatoryRelease(releases []*github.RepositoryRelease) (*github.RepositoryRelease, error) { var latestMandatoryRelease *github.RepositoryRelease for _, release := range releases { @@ -42,6 +46,7 @@ func (c *UpdateChecker) GetLatestMandatoryRelease(releases []*github.RepositoryR return latestMandatoryRelease, nil } +// Compares the current karmor version and the mandatory release present in releases func (c *UpdateChecker) CompareVersions(currentVersion string, latestMandatoryRelease *github.RepositoryRelease) error { if latestMandatoryRelease == nil { color.HiGreen("The client is up to date.") @@ -58,6 +63,7 @@ func (c *UpdateChecker) CompareVersions(currentVersion string, latestMandatoryRe return nil } +// Checks for releases in kubearmor-client repository and displays a log if update is present func (c *UpdateChecker) CheckForUpdates() error { releases, err := c.FetchReleases() if err != nil { @@ -77,12 +83,14 @@ func (c *UpdateChecker) CheckForUpdates() error { return nil } +// NewUpdateChecker : Returns a new instance of UpdateChecker func NewUpdateChecker() *UpdateChecker { return &UpdateChecker{ Client: github.NewClient(nil), } } +// Init function for call UpdateChecker functions func (c *UpdateChecker) Init() error { err := c.CheckForUpdates() if err != nil { diff --git a/utils/portforward.go b/utils/portforward.go index cf509831..db1817a6 100644 --- a/utils/portforward.go +++ b/utils/portforward.go @@ -1,3 +1,4 @@ +// Package utils provides utility for port forwarding. package utils import ( diff --git a/version/version.go b/version/version.go index 83e85c0a..7288bfa3 100644 --- a/version/version.go +++ b/version/version.go @@ -35,6 +35,7 @@ func PrintVersion(c *k8s.Client) error { return nil } +// GetKubeArmorVersion :Returns the current version of KubeArmor func GetKubeArmorVersion(c *k8s.Client) (string, error) { pods, err := c.K8sClientset.CoreV1().Pods("kube-system").List(context.Background(), metav1.ListOptions{LabelSelector: "kubearmor-app=kubearmor"}) if err != nil {