Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade hugo and docsy version (add dark theme) #3954

Open
milinddethe15 opened this issue Jan 12, 2025 · 4 comments · May be fixed by #3981
Open

Upgrade hugo and docsy version (add dark theme) #3954

milinddethe15 opened this issue Jan 12, 2025 · 4 comments · May be fixed by #3981
Assignees

Comments

@milinddethe15
Copy link
Contributor

@thesuperzapper
Copy link
Member

We run a highly custom version of docsy theme, see the overrides in the layouts/ folder, so it will probably be a very large amount of work.

It might even be easier to make our own light/dark mode, but I am not sure because this may require updating all the pages and make our overrides even worse, we should check how they did it on the upstream docsy repo, and see if it was just a change in the common page templates.

@milinddethe15
Copy link
Contributor Author

google/docsy#1909 added the dark mode feature in docsy.

I will give a try to implement this here.

@milinddethe15
Copy link
Contributor Author

/assign @milinddethe15

@thesuperzapper thesuperzapper changed the title Upgrade hugo and docsy version Upgrade hugo and docsy version (add dark theme) Jan 16, 2025
@thesuperzapper thesuperzapper linked a pull request Jan 31, 2025 that will close this issue
@thesuperzapper
Copy link
Member

I have created a PR that will add a dark theme, while retaining the hugo/docsy version as doing the upgrade would have been nearly impossible given our customizaions to the theme:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants