Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure CLI authentication #6730

Open
comtalyst opened this issue Aug 2, 2024 · 1 comment
Open

Support Azure CLI authentication #6730

comtalyst opened this issue Aug 2, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@comtalyst
Copy link
Contributor

What would you like to be added:

Authentication through Azure CLI credentials, similar to https://github.com/kubernetes/autoscaler/pull/4295/files.
Note that that part of autoscaler used to share the code with this cloud-provider-azure. Thus, required changes here should be similar to that PR.

Why is this needed:

This additional authentication method should ease the development process for projects that use cloud-provider-azure, such as Cluster Autoscaler.
In fact, from the above PR, it already exists in autoscaler, but through forking means. Other components would benefit from that as well if we add it here. Not to mention better code organization between Cluster Autoscaler and cloud-provider-azure (i.e., we don't have to do surgery on the code like this and can rely more on abstraction).

In addition, newer DefaultAzureCredential() seems to include this auth method as well: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/README.md#defaultazurecredential. Maybe that's being used for track2 already?

@comtalyst comtalyst added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 2, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants