chore: move event reasons to the package and as constants #1915
Conversation
Signed-off-by: flavono123 <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flavono123 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
|
Welcome @flavono123! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @flavono123. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
|
when i tried a local test with the package i fixed, seems some settings are required concerned with kubebuilder, but it is not covered in any docs or different with a normal kubebuilder installation. how can i test in my local?: ❯ go test ./pkg/controllers/disruption/
Running Suite: Disruption - /Users/hansuk.hong/T/karpenter/pkg/controllers/disruption
=====================================================================================
Random Seed: 1736918483
Will run 175 of 175 specs
------------------------------
[BeforeSuite] [PANICKED] [0.015 seconds]
[BeforeSuite]
/Users/hansuk.hong/T/karpenter/pkg/controllers/disruption/suite_test.go:90
[PANICKED] Test Panicked
In [BeforeSuite] at: /Users/hansuk.hong/go/1.23.4/pkg/mod/github.com/samber/[email protected]/errors.go:53 @ 01/15/25 14:21:24.002
unable to start control plane itself: failed to start the controlplane. retried 5 times: fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory
Full Stack Trace
github.com/samber/lo.must({0x1027b2be0, 0x140000ca340}, {0x0, 0x0, 0x0})
/Users/hansuk.hong/go/1.23.4/pkg/mod/github.com/samber/[email protected]/errors.go:53 +0x1cc
github.com/samber/lo.Must[...](...)
/Users/hansuk.hong/go/1.23.4/pkg/mod/github.com/samber/[email protected]/errors.go:65
sigs.k8s.io/karpenter/pkg/test.NewEnvironment({0x140002f7748?, 0x0?, 0x0?})
/Users/hansuk.hong/T/karpenter/pkg/test/environment.go:133 +0x304
sigs.k8s.io/karpenter/pkg/controllers/disruption_test.init.func4()
/Users/hansuk.hong/T/karpenter/pkg/controllers/disruption/suite_test.go:91 +0xa8
------------------------------
[AfterSuite] [PANICKED] [0.000 seconds]
[AfterSuite]
/Users/hansuk.hong/T/karpenter/pkg/controllers/disruption/suite_test.go:104
[PANICKED] Test Panicked
In [AfterSuite] at: /Users/hansuk.hong/.goenv/versions/1.23.4/src/runtime/panic.go:262 @ 01/15/25 14:21:24.002
runtime error: invalid memory address or nil pointer dereference
Full Stack Trace
sigs.k8s.io/karpenter/pkg/test.(*Environment).Stop(0x0)
/Users/hansuk.hong/T/karpenter/pkg/test/environment.go:169 +0x1c
sigs.k8s.io/karpenter/pkg/controllers/disruption_test.init.func5()
/Users/hansuk.hong/T/karpenter/pkg/controllers/disruption/suite_test.go:105 +0x24
------------------------------
Summarizing 2 Failures:
[PANICKED!] [BeforeSuite]
/Users/hansuk.hong/go/1.23.4/pkg/mod/github.com/samber/[email protected]/errors.go:53
[PANICKED!] [AfterSuite]
/Users/hansuk.hong/.goenv/versions/1.23.4/src/runtime/panic.go:262
Ran 0 of 175 Specs in 0.015 seconds
FAIL! -- A BeforeSuite node failed so all tests were skipped.
--- FAIL: TestAPIs (0.02s)
FAIL
FAIL sigs.k8s.io/karpenter/pkg/controllers/disruption 0.536s
FAIL |
Fixes #1897
Description
eventseventsis enough overapisor under thatHow was this change tested?
eventspackage."InsufficientCapacityError"which also is incloudprovider/metricspackage.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.