Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After installing with go install kustomize version is always (devel), but should be v5.x.x #5845

Open
dmvolod opened this issue Jan 16, 2025 · 1 comment · May be fixed by #5846
Open

After installing with go install kustomize version is always (devel), but should be v5.x.x #5845

dmvolod opened this issue Jan 16, 2025 · 1 comment · May be fixed by #5846
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@dmvolod
Copy link

dmvolod commented Jan 16, 2025

What happened?

A #5339 was submitted and fixed, but seems to not enough for correct displaying version.

[xyz@fedora kubernetes]$ GOBIN=$(pwd)/ GO111MODULE=on go install sigs.k8s.io/kustomize/kustomize/[email protected]
[xyz@fedora kubernetes]$ ./kustomize version
(devel)
[xyz@fedora kubernetes]$

What did you expect to happen?

I expected to see correct kustomize version which was builded from remote source tag.
It seems to version should be get from the BuildInfo.Main.Version on the last stage if the version got from the info.Deps is still (devel)
Will provide fix soon.

How can we reproduce it (as minimally and precisely as possible)?

Not a problem with kustomize yaml functions

Expected output

Not a problem with kustomize yaml functions

Actual output

Not a problem with kustomize yaml functions

Kustomize version

v5.6.0

Operating system

Linux

@dmvolod dmvolod added the kind/bug Categorizes issue or PR as related to a bug. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 16, 2025
@koba1t
Copy link
Member

koba1t commented Jan 17, 2025

HI @dmvolod
I agree to add the correct version info when go install.

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
3 participants