Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OpenShift provider should not use DeploymentConfigs (anymore) #1903

Open
jacksgt opened this issue Jun 20, 2024 · 2 comments
Open

[BUG] OpenShift provider should not use DeploymentConfigs (anymore) #1903

jacksgt opened this issue Jun 20, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jacksgt
Copy link

jacksgt commented Jun 20, 2024

Expected Behavior

Kompose should use regular Kubernetes Deployments also with --provider=openshift.

Actual Behavior

When invoking kompose convert --provider=openshift, kompose currently creates DeploymentConfig objects for each docker compose service.
However, as of Openshift 4.14 DeploymentConfigs are deprecated.
The Openshift web console shows the following warning:

Screenshot 2024-06-20 at 12-44-45 DeploymentConfigs · OKD

The oc CLI shows this warning:

$ oc get deploymentconfig 
Warning: apps.openshift.io/v1 DeploymentConfig is deprecated in v4.14+, unavailable in v4.10000+

Steps To Reproduce

kompose convert -f docker-compose.yml --provider=openshift

Kompose Version

1.32.0 (HEAD)

Docker-Compose file

version: '3.2'

services:
  changedetection:
    image: ghcr.io/dgtlmoon/changedetection.io
    container_name: changedetection
    volumes:
      - changedetection-data:/datastore
    environment:
      - LOGGER_LEVEL=INFO
      - PLAYWRIGHT_DRIVER_URL=ws://playwright-chrome:3000
      - HIDE_REFERER=true
    ports:
     - 5000
    restart: unless-stopped
  playwright-chrome:
    image: dgtlmoon/sockpuppetbrowser:latest
    restart: unless-stopped
    environment:
      - SCREEN_WIDTH=1920
      - SCREEN_HEIGHT=1024
      - SCREEN_DEPTH=16
      - MAX_CONCURRENT_CHROME_PROCESSES=2
    ports:
      - 3000
volumes:
  changedetection-data:

Anything else?

https://docs.openshift.com/container-platform/4.15/applications/deployments/what-deployments-are.html

@jacksgt jacksgt added the kind/bug Categorizes issue or PR as related to a bug. label Jun 20, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants