Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --etc-upgrade flag to kubeadm upgrade plan #3155

Open
tiesmaster opened this issue Jan 31, 2025 · 3 comments
Open

Add --etc-upgrade flag to kubeadm upgrade plan #3155

tiesmaster opened this issue Jan 31, 2025 · 3 comments
Labels
area/upgrades kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@tiesmaster
Copy link

What would you like to be added?

Add the flag --etc-upgrade that is present on kubeadm upgrade apply also to the subcommand kubeadm upgrade plan. If you specify this, then the etcd upgrade versions won't be calculcated, and it states no upgrade version for etcd (similar to like how plan won't show a version when it detects that external etcd is in use).

Why is this needed?

To align the flags between the subcommands plan, and apply. There are already a bunch of flags to control the target version (--allow-*-upgrades), and they exist on both subcommands. On the apply you also have the flag to disable upgrading etcd, but you don't have that on plan, so this won't allow you to see what plan exactly would upgrade. Adding this flag will allow the user to exactly see what would happen when running the apply subcommand subsequent to the plan invocation.

/sig cluster-lifecycle
/cc @neolit123

Slack discussion: https://kubernetes.slack.com/archives/C2P1JHS2E/p1738258436793859

@tiesmaster tiesmaster added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jan 31, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 31, 2025
@neolit123
Copy link
Member

/transfer kubeadm

@k8s-ci-robot k8s-ci-robot transferred this issue from kubernetes/kubernetes Jan 31, 2025
@neolit123 neolit123 added priority/backlog Higher priority than priority/awaiting-more-evidence. area/upgrades and removed sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 31, 2025
@neolit123
Copy link
Member

neolit123 commented Jan 31, 2025

there is also an configuration api (--config) where this is present for apply.

@neolit123 neolit123 added this to the v1.33 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/upgrades kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants