Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docs to add InheritDefaultEvictionValues feature gate #48601

Open
vaibhav2107 opened this issue Oct 31, 2024 · 3 comments
Open

Update the docs to add InheritDefaultEvictionValues feature gate #48601

vaibhav2107 opened this issue Oct 31, 2024 · 3 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@vaibhav2107
Copy link
Member

This is a Feature Request

This issue is created regarding the k/k PR #127577

What would you like to be added

Update the docs to add the InheritDefaultEvictionValues feature gate that will cause change in behaviour of the default values of the eviction hard parameters. Existing behaviour can also be executed by disabling the feature gate.

Why is this needed
Currently if the default values of any one of the parameters of eviction hard is changed, then the other parameters are set to 0. After the introduction of the new feature gate, if default value of any of the parameter of eviction hard is changed then the other parameters will inherit their default values.

Comments

@vaibhav2107 vaibhav2107 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 31, 2024
@vaibhav2107
Copy link
Member Author

/language en
/sig node

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 31, 2024
@vaibhav2107
Copy link
Member Author

/assign
I'll work on this and open the PR once the code PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

2 participants