Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build matrix to CI with optional features #59

Open
rursprung opened this issue May 26, 2022 · 0 comments
Open

add build matrix to CI with optional features #59

rursprung opened this issue May 26, 2022 · 0 comments

Comments

@rursprung
Copy link

it seems that currently optional features (chrono & aq_unstable at this time) are not being tested by the CI workflow. i'd suggest adding a build matrix which covers also these features.

see e.g. what i did in rursprung/r2d2-oracle#15 for using a build matrix with features. with #58 i'm adding a build matrix to this repo here anyway, so maybe you could then directly extend that and just add the features to the matrix as well (so that they're also tested with both versions of rust and on all OS). you might want to test all four combinations (no features, all features and each feature individually) or just two of them: all features and no features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant