You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here is a screenshot of showing decimation_level metadata and channel summary dataframe having two different values for
sample_rate_decimation_level.
in mt_metadata/transfer_functions/processing/fourier_coefficients/standards/fc_channel.json this field is described as
"Sample rate of the decimation level."
Should probably
Update the metadata description to say:
"Sample rate of the time series that was Fourier transformed to generate the FC decimation level."
after agreement that this is what is intended.
Review the methods that generate this value and repair. It looks like the bogus value it is coming from max frequency of the FC array *2, but this is not general beacause in general we have no guarantee that frequencies up to and including the Nyquist will be stored in the FC container. The relevant py files are in mth5/groups/
fourier_coefficients.py
fc_dataset.py
Probably best if the value in the dataframe were taken from the metadata (and never computed). Hopefully this make a singe place where the info is sourced.
Add a test that at least confirms that dec_level.metadata.sample_rate_decimation_level and the fc_level channel_summary df column agree.
The text was updated successfully, but these errors were encountered:
- fc_dataset:
- frequency property does not assume full half spectrum, but gets frequencies
from linspace (frequecy_min, frequency_max)
- added doc string about assumption of uniform sampling
- require sample_rate to be passed to fc_dataset when building from xarray
- fourier_coefficients:
- add properties frequency_min, frequency_max
- added test condfirm fc summary has correct sample rate
Here is a screenshot of showing decimation_level metadata and channel summary dataframe having two different values for
sample_rate_decimation_level.
in mt_metadata/transfer_functions/processing/fourier_coefficients/standards/fc_channel.json this field is described as
"Sample rate of the decimation level."
Should probably
"Sample rate of the time series that was Fourier transformed to generate the FC decimation level."
after agreement that this is what is intended.
Probably best if the value in the dataframe were taken from the metadata (and never computed). Hopefully this make a singe place where the info is sourced.
The text was updated successfully, but these errors were encountered: