clarify synthetic data channel labels #236
Comments
kkappler
changed the title
kkappler
added a commit
that referenced
this issue
Aug 29, 2024
A synthetic e-field flip correction was recently added This reversed the polarity of the 'ex', 'ey' columns of dataframe right after it gets read-in. However, the dataframe column names come from the channel nomenclature, and these can be, for example 'e1', 'e2'. Some notes about a permanent fix are in #236
kujaku11
added a commit
that referenced
this issue
Aug 29, 2024
hotfix synthetic electric field polarity (#236)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The synthetic ascii data from EMTF columns are ordered:
but the fact that we label these correctly is just a happy accident that channel_nomenclature's channel_map has that same ordering.
A good fix in general would be to replace these archaic ascii files with csv, with column headings ("hx", "hy", "hz", "ex", "ey").
Then the synthetic run can rename the columns based on the appropriate channel_nomenclature.
The text was updated successfully, but these errors were encountered: