Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non strict routing not respected #210

Open
aandis opened this issue May 14, 2020 · 1 comment
Open

Non strict routing not respected #210

aandis opened this issue May 14, 2020 · 1 comment
Labels
enhancement help wanted

Comments

@aandis
Copy link

aandis commented May 14, 2020

apicache uses the url as the key for caching responses. So even when the express app is not using strict routing (/foo and /foo/ are equivalent) you can end up with different responses because the cache key is different.
aandis added a commit to aandis/apicache that referenced this issue May 14, 2020
@aandis
Failing test for kwhitley#210
84d4550
@aandis
Copy link
Author

aandis commented May 14, 2020

Here's a quick failing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwhitley @aandis