-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action to apply patchset to a target kernel tree and branch #79
Comments
Hey @rodrigosiqueira, and sorry for bothering you. Could you check if the steps I described for applying a patchset make sense? |
I've just started implementing some accessory stuff to implement this (config options, ui, etc) |
Nice! In our offline conversation, I think I explained the same as described in this issue. I will mark you as an assignee just for tracking. |
|
Hi @davidbtadokoro , this sequence looks great! Just try to define some defaults but also provide an option for the user to change them. For example, for the branch name, maybe let the user define something different as a prefix (e.g., PATCHES_REVIEW-..., PATCHES_FOR_VERSION_X_..., etc) |
Nice hint, implemented |
Thanks for reviewing the steps and for the idea! I totally agree with this approach and welcome more suggestions if you have 🙏 |
Description:
A core expected feature of
patch-hub
is to apply a patchset on top of a kernel tree and branch through the tool. This action encompasses some steps:2a. (optional) If it is possible to save the dirty state (with stashing, for example), we should
<base-branch>-<patchset-ID>-timestamp>
. IMHO, the<patchset-ID>
should be human-readable and easily relatable to the patchset~/.cache/patch-hub/patchsets/
)git am <applicable-patchset>
.reviewed_patchset.json
) to keep track of these runs and be able to display them in different forms.6a. (optional) If the patchset application fails, use a generated
.rej
file and prompt the user ifpatch-hub
can try to "force-applying" it (withwiggle
, for example).Steps marked with optional mean that, at least in the first version, we can simplify the feature and add these complexities later.
Motivation:
This feature is a must, not only because this is one of the reviewing workflows that
patch-hub
aims to cover but also because the action of issuing a kernel build has the patchset application as a pre-requisite.The text was updated successfully, but these errors were encountered: