From 64321f0c929613b16ec7dae48201cd67afe14c6b Mon Sep 17 00:00:00 2001 From: Oliwia Gowor Date: Tue, 22 Oct 2024 15:42:04 +0200 Subject: [PATCH 1/4] fix: ui5 codemode adjustments --- .../BusolaExtensionDetails.js | 3 +- .../BusolaExtensions/ColumnsInput.js | 2 +- .../Clusters/components/AddClusterDialog.js | 2 +- .../Clusters/components/AddClusterWizard.js | 6 +-- .../Clusters/components/AuthForm.js | 2 +- .../KubeconfigUpload/KubeconfigFileUpload.js | 4 +- .../ClusterValidation/ClusterValidation.tsx | 17 +++------ .../ClusterValidationConfiguration.js | 2 +- .../components-form/Modules/Modules.js | 4 +- .../components-form/MultiType.js | 2 +- .../Extensibility/components/ExternalLink.js | 3 +- .../components/ExternalLinkButton.js | 3 +- .../components/ResourceButton.js | 3 +- .../Extensibility/components/Wizard.js | 2 +- .../KymaModules/KymaModulesAddModule.js | 4 +- .../KymaModules/KymaModulesCreate.js | 4 +- src/components/Preferences/Preferences.tsx | 4 +- .../ResourceValidationSettings.tsx | 6 +-- src/resources/Events/EventDetails.js | 2 +- src/resources/Events/EventList.js | 2 +- .../YamlUpload/ResourceValidationResult.js | 2 +- .../YamlUpload/YamlResourcesList.js | 6 ++- .../Namespaces/YamlUpload/YamlUploadDialog.js | 2 +- .../RoleBindings/GenericRoleBindingCreate.js | 2 +- src/resources/Roles/InvalidRoleError.js | 2 +- src/resources/Roles/RuleInput.js | 3 +- .../ServiceAccounts/ServiceAccountCreate.js | 2 +- .../TokenRequestModal/TokenRequestModal.tsx | 2 +- .../ResourceForm/ForceUpdateModalContent.tsx | 2 +- .../ResourceForm/components/ModeSelector.js | 2 +- .../ResourceForm/components/ResourceForm.js | 11 +----- src/shared/ResourceForm/fields/DataField.js | 2 +- src/shared/ResourceForm/fields/ItemArray.js | 2 +- .../components/CopiableText/CopiableText.js | 3 +- .../components/Deployment/Containers.js | 2 +- .../DescriptionHint/DescriptionHint.tsx | 6 +-- .../DynamicPageComponent.js | 21 +++++----- .../EmptyListComponent/EmptyListComponent.tsx | 2 +- .../components/GenericList/GenericList.js | 3 +- .../components/GenericList/components.js | 38 ++++++++++--------- .../components/ListActions/ListActions.js | 2 +- src/shared/components/Modal/Modal.js | 2 +- .../components/ModalWithForm/ModalWithForm.js | 5 +-- .../components/MonacoEditorESM/Editor.js | 4 +- .../components/PopoverBadge/PopoverBadge.tsx | 4 +- .../ResourceRef/ExternalResourceRef.js | 4 +- .../components/SchemaViewer/JSONSchema.js | 3 +- .../components/SchemaViewer/SchemaViewer.js | 6 +-- .../components/ServiceAccountTokenStatus.tsx | 4 +- src/shared/contexts/ErrorModal/ErrorModal.tsx | 2 +- src/shared/hooks/useProtectedResources.js | 4 +- 51 files changed, 104 insertions(+), 128 deletions(-) diff --git a/src/components/BusolaExtensions/BusolaExtensionDetails.js b/src/components/BusolaExtensions/BusolaExtensionDetails.js index 9b0532e379..a19c6a33d1 100644 --- a/src/components/BusolaExtensions/BusolaExtensionDetails.js +++ b/src/components/BusolaExtensions/BusolaExtensionDetails.js @@ -193,8 +193,7 @@ export function BusolaExtensionDetails({ name, namespace }) { <> - } > - {!scanReady && } -
{ />
- {scanProgress && (
{ } valueState={ scanProgress && scanProgress.total === scanProgress.scanned - ? 'Success' + ? 'Positive' : 'None' } style={{ width: '96%', padding: '5px 2%' }} />
)} - {scanResult && (
)} - {createPortal( ) : ( header diff --git a/src/components/Clusters/views/ClusterOverview/ClusterValidation/ClusterValidationConfiguration.js b/src/components/Clusters/views/ClusterOverview/ClusterValidation/ClusterValidationConfiguration.js index 7b0c6e6b4f..96336316f6 100644 --- a/src/components/Clusters/views/ClusterOverview/ClusterValidation/ClusterValidationConfiguration.js +++ b/src/components/Clusters/views/ClusterOverview/ClusterValidation/ClusterValidationConfiguration.js @@ -186,7 +186,7 @@ export function ClusterValidationConfigurationDialog({ return ( { if (!name) return ( - + {t('extensibility.widgets.modules.no-modules')} ); @@ -213,7 +213,7 @@ export function Modules({ storeKeys, resource, onChange, schema, required }) { {parsedOptions?.betaAlert && isBeta && isChecked ? ( diff --git a/src/components/Extensibility/components-form/MultiType.js b/src/components/Extensibility/components-form/MultiType.js index e560ba0699..b66ed8c003 100644 --- a/src/components/Extensibility/components-form/MultiType.js +++ b/src/components/Extensibility/components-form/MultiType.js @@ -63,7 +63,7 @@ export function MultiType({ { onChange && onChange({ diff --git a/src/components/Extensibility/components/ExternalLink.js b/src/components/Extensibility/components/ExternalLink.js index 8650b0d494..b419d00248 100644 --- a/src/components/Extensibility/components/ExternalLink.js +++ b/src/components/Extensibility/components/ExternalLink.js @@ -52,9 +52,8 @@ export const ExternalLink = ({ if (structure.type === 'button') { return (