Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Custom resources details wrong opening #3629

Merged
merged 2 commits into from
Jan 27, 2025
Merged

fix: Custom resources details wrong opening #3629

merged 2 commits into from
Jan 27, 2025

Conversation

KonradPietocha
Copy link
Contributor

@KonradPietocha KonradPietocha commented Jan 24, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • using Suspense to gently open the columns,
  • removing unnecessary scroll under list item.

Related issue(s)
Closes #3533

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2025
@KonradPietocha KonradPietocha changed the title Custom resources details wrong opening fix: Custom resources details wrong opening Jan 24, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 27, 2025
@mrCherry97 mrCherry97 merged commit 4168cf8 into kyma-project:main Jan 27, 2025
57 of 65 checks passed
@KonradPietocha KonradPietocha deleted the custom-resources-details-wrong-opening branch January 27, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Details of the Custom Resources are opening from the left side
3 participants
@KonradPietocha @mrCherry97 @kyma-bot