Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All resources introduced by keda module should be labelled with kyma-project.io/module=keda #571

Open
kwiatekus opened this issue Jan 23, 2025 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@kwiatekus
Copy link
Contributor

kwiatekus commented Jan 23, 2025

Description

As described by this decision, all resources introduced by a keda module should be labeled with kyma-project.io/module=keda

This includes all resources that make the "keda manager" (deployments, rbacs, CRD etc) as well as resources managed by keda manager:

  • Resources introduced by keda manifest (i.e resources installed by LFM )
  • Resources managed by keda-manager (the ones keda manager installs)

keda manage should enrich installed resources with kyma-project.io/module=keda
Do not add them directly to keda.yaml file as we take it as-is from upstream in case of upgrading to latest keda version

Actual result

kubectl get all -l kyma-project.io/module=keda -A
No resources found

kubectl get crd -l kyma-project.io/module=keda
No resources found
@kwiatekus kwiatekus added kind/bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant