Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation webhook for LogPipelines #1392

Closed
a-thaler opened this issue Aug 27, 2024 · 2 comments
Closed

Remove validation webhook for LogPipelines #1392

a-thaler opened this issue Aug 27, 2024 · 2 comments
Labels
area/logs LogPipeline kind/feature Categorizes issue or PR as related to a new feature.

Comments

@a-thaler
Copy link
Collaborator

a-thaler commented Aug 27, 2024

Description
Out of the experiences gathered, an advanced validation of a pipeline should not be done in a webhook as it takes time, might not be available and anyway need to get repeated at server side again.
Syntactical checks can be done nicely in the CRD definition already.

So the gola is to move all parts of the current webhook to an adequate replacement and get rid of the webhook

Criterias

  • The webhook is removed
  • All validation got replaced by adequate replacements

Tasks
- [ ] Move unsupported mode warning
- [ ] Max Pipeline check to be executed on backend side similar to TracePipeline, having proper status change
- [ ] Singleton check for telemetry resource #555
- [ ] Plugin validation with supported list and hardcoded available plugin list as backend validation feature reflected via status change
- [ ] Missing file/variable reference validation
- [x] Delete dry-run and get manager image free (#1234)
- [ ] Move API validation into CRD schema validation
- [ ] Delete webhook

Reasons

Attachments

Release Notes


@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/logs LogPipeline labels Aug 27, 2024
Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2024
@a-thaler a-thaler removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 28, 2024
@a-thaler
Copy link
Collaborator Author

We decided to stay with the validating webhook. The heavy operation of performing dry-runs was removed. We anyway will not get rid of webhooks and the cert mechanism seem to work reliable. So instead we will focus on shifting to OTEL and remove the webhook once we remove fluentbit

@a-thaler a-thaler closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant