Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align existing status API of logs and traces with syntactical kubernetes conventions #772

Closed
a-thaler opened this issue Feb 5, 2024 · 0 comments
Assignees
Labels
area/logs LogPipeline area/traces TracePipeline kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@a-thaler
Copy link
Collaborator

a-thaler commented Feb 5, 2024

Description
As part of transitioning to a beta API the pipeline status needs to be aligned. Here the first step for it:

  • Carry over missing required fields (Status, Message) from metav1.Condition to telemetryv1alpha1.LogPipelineCondition, telemetryv1alpha1.TracePipelineCondition, telemetryv1alpha1.LogParserCondition. However, define them as optional.
  • Adapt the corresponding controllers to set these fields to some meaningful values
  • Investigate if it is possible to adapt the runtime monitoring agent to reflect the new Status field in the CR-generated metrics

Reasons

Step number 1 described in https://github.com/kyma-project/telemetry-manager/blob/main/docs/contributor/arch/004-consolidate-pipeline-statuses.md

Attachments

Release Notes


@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/logs LogPipeline area/traces TracePipeline labels Feb 5, 2024
@a-thaler a-thaler mentioned this issue Feb 5, 2024
20 tasks
@shorim shorim self-assigned this Feb 6, 2024
@shorim shorim modified the milestones: 1.9.0, 1.10.0 Feb 6, 2024
@shorim shorim closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline area/traces TracePipeline kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants