Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probabilities are handled in the wrong file for some skills #44

Open
bm3719 opened this issue Jul 5, 2020 · 0 comments
Open

Probabilities are handled in the wrong file for some skills #44

bm3719 opened this issue Jul 5, 2020 · 0 comments

Comments

@bm3719
Copy link
Contributor

bm3719 commented Jul 5, 2020

Some illu and I think DK skills have the probabilty figured in L1SkillUse. For the sake of consistency, I'm pretty sure this should be handled in L1Magic, then called with L1Magic.calcProbabilty().

Best case it has no functional difference, worst case we're accidentally figuring it twice for no reason, worst worst case, its giving players a double roll for probability (I think something like that was already fixed once for an illu skill)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant