-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register Julia Package #86
Comments
@Luthaf @ceriottm -- I'd like to finally register the Julia package in the Julia registry. Can one of you please setup the registrator bot? If you prefer to not manage any part of the Julia implementation, then we should consider moving this implementation out into a separate repository that could still be linked from your repo. Let me know what you prefer. |
Hi @cortner we should definitely do this from the repo. Sorry if this lagged behind, we were trying to also get a CUDA+JAX version up and running. Perhaps we could do this at the same time as we release the version 0.4.0 of the Python package. |
I dont see a rationale for delaying. In Julia you Register new versions basically everyone you merge a PR. I'm relying on that mechanism and right now I can't tag updates in other packages because they depend on have sphericart registered. |
OK. @Luthaf will look into it!
|
The registrator bot should be installed! I'm not sure what syntax to use with it to register a package in a sub-folder though; but the online page in https://juliahub.com/ui/Registrator supports it. |
Thank you - I will give it a try. If it is not possible for me to trigger it I'll let you know. Worst case I make a manual PR to General. |
Unless you have a different idea I will register as 0.0.3 the reason being that there is a possible future thread-safety issue in how I manage memory. We are looking into changing this and once we've settled I would then go to 0.1.x |
Good for me. Moving forward I think we should try to harmonize a bit the APIs. I like a lot that we are converging on a central place to develop this kind of low-level libraries across platforms (and very grateful you decided to contribute to this repo rather than making a separate one) but I think we are not making the most of it if we don't try to share some of the boilerplate stuff to lower maintenance costs. |
That's fine of course and another reason to not yet tag 0.1 |
@JuliaRegistrator register subdir=julia |
Error while trying to register: Register Failed |
@ceriottm / @Luthaf - so this is what I was afraid of. If I can't tag new versions then I'm not sure it is practical to keep the package here. I have to be able to make quick bugfixes, so I'll need somebody to review & merge PRs rapidly, but also I have to be able to manage the Julia package as I need to. So there are three options:
You need to think about what you want. As a general rule, I think if you want to have code shared broadly you need to open up participation. As a matter of principle I normally do not contribute code to repos owned by other research groups. This was an exception and given the brain-space overhead this is causing me I'm now regretting it a bit. I wonder whether option 3 will be the most practical for everybody. I can still commit to maintaining compatibility, keeping documentation in your repo, etc. Just let me know what you think - I certainly don't have any agenda here. |
Made you a member. I don't see any issue with that, nor to give you write or maintainer permissions to this repo. Usually when projects grow into something substantial I like to spin then into a separate org, but I think we're fat from that here |
ok thank you, that will certainly make life easier. I just didn't want to presume anything. Also agreed about not having to "spin it out" quite yet. |
@JuliaRegistrator register subdir=julia |
Error while trying to register: Register Failed |
@JuliaRegistrator register subdir=julia |
Registration pull request created: JuliaRegistries/General/98788 Tip: Release NotesDid you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
To add them here just re-invoke and the PR will be updated. TaggingAfter the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version. This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
Also, note the warning: This looks like a new registration that registers version 0.0.3. |
@ceriottm -- sorry to ping you again Friday evening.
There are a few things I need to fix that will possibly require a succession of merged commits. If I can get push access then I can do this relatively quickly. |
Done, you're added with write access, you def should have it if you keep looking after the Julia part, no questions. I think it'd be still good to avoid direct commits to master, but I am not sure of what you exactly need to do and you probably are more git-savy than I ^_^ |
thank you - I'll try to do the registration on a branch. Let's see how this goes. |
@JuliaRegistrator register subdir=julia branch=co/jlreg |
Registration pull request updated: JuliaRegistries/General/98788 Tip: Release NotesDid you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
To add them here just re-invoke and the PR will be updated. TaggingAfter the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version. This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
Also, note the warning: This looks like a new registration that registers version 0.0.3. |
looks like this is finally happening. The julia version will be registered after a standard waiting period of 3 days. (because it is a new package) I will now merge the registration branch into main. |
Just for information to avoid confusion: by tagging the registered Julia version I created a release (I was unaware this would happen). I deleted this release again. Apologies for the noise. |
I will keep this open and use it to register future versions of the Julia package. |
@JuliaRegistrator register subdir=julia branch=julia |
Registration pull request created: JuliaRegistries/General/107465 Tip: Release NotesDid you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
To add them here just re-invoke and the PR will be updated. TaggingAfter the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version. This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
|
@JuliaRegistrator register subdir=julia branch=julia |
Registration pull request created: JuliaRegistries/General/108509 Tip: Release NotesDid you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
To add them here just re-invoke and the PR will be updated. TaggingAfter the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version. This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
|
@Luthaf -- I can no longer autoregister new package versions. The auto merging guidelines require the following:
Would you be happy to rename one of the license files to Not being able to run CI on just the Julia code makes developing in this repo a huge pain for me. Not merging regularly into main isn't great either. Not being able to automerge new versions kills it. We may need to revisit this. I wonder if it is simpler for everybody if I move the code into a separate repo afterall, but keep Julia in the docs, link to the Julia repo, maybe even add a CI task to your repo that checks compatibility. (which we really shoudl do anyhow...) |
@JuliaRegistrator register subdir=julia branch=julia |
Registration pull request updated: JuliaRegistries/General/108509 Tip: Release NotesDid you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
To add them here just re-invoke and the PR will be updated. TaggingAfter the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version. This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
|
@JuliaRegistrator register subdir=julia branch=julia |
Registration pull request updated: JuliaRegistries/General/108509 Tip: Release NotesDid you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
To add them here just re-invoke and the PR will be updated. TaggingAfter the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version. This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
|
@Luthaf and @ceriottm -- I can no longer autoregister new package versions. The auto merging guidelines require the following:
Would you be happy to rename one of the license files to Not being able to run CI on just the Julia code makes developing in this repo a huge pain. Not merging regularly into main isn't great either. Not being able to automerge new versions kills it. We may need to revisit this. I wonder if it is simpler for everybody if I move the code into a separate repo afterall, but keep Julia in the docs, link to the Julia repo, maybe even add a CI task to your repo that checks compatibility. (which we really shoudl do anyhow...) |
Hi @cortner I def see no issue renaming the license file - actually it looks like there is already a file called |
I don't think I should merge into |
@JuliaRegistrator register subdir=julia branch=julia |
Registration pull request updated: JuliaRegistries/General/108509 Tip: Release NotesDid you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
To add them here just re-invoke and the PR will be updated. TaggingAfter the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version. This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
|
@JuliaRegistrator register subdir=julia branch=julia |
Registration pull request updated: JuliaRegistries/General/108509 Tip: Release NotesDid you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
To add them here just re-invoke and the PR will be updated. TaggingAfter the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version. This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
|
@ceriottm -- Thanks. I've solved the current problem. I'll try over the course of the summer to solve the remaining ones as well. |
I'm happy to merge PR from the julia branch to the main branch! My main concern there is making sure CI keeps working, hence the delay when merging the previous one. But in general if the only changes concern the julia code, I can try to merge PR quickly! |
To register the Julia package with the General Registry one needs to
Project.toml
- we need to decide on 0.0.2 or 0.1.0; I don't mind either way, I think it is ready for 0.1.0.The text was updated successfully, but these errors were encountered: