Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a built-in neighbor list "filter" for tuning functions #151

Open
GardevoirX opened this issue Jan 22, 2025 · 0 comments · May be fixed by #167
Open

Add a built-in neighbor list "filter" for tuning functions #151

GardevoirX opened this issue Jan 22, 2025 · 0 comments · May be fixed by #167
Assignees
Labels
good first issue Good for newcomers

Comments

@GardevoirX
Copy link
Contributor

Suggested by @ceriottm, in cases where users want to optimize the cutoff, it would be nice to have a built-in "filter", so the user can do the NL calculation with a large cutoff for only once, and then reuse the result during the optimization. Along with this update, new tests shall be designed and added.

For reference:

def filter_neighbors(cutoff, neighbor_indices, neighbor_distances):
assert cutoff <= max_cutoff
filter_idx = torch.where(neighbor_distances <= cutoff)
return neighbor_indices[filter_idx], neighbor_distances[filter_idx]

@GardevoirX GardevoirX added the good first issue Good for newcomers label Jan 22, 2025
@GardevoirX GardevoirX self-assigned this Feb 4, 2025
@GardevoirX GardevoirX linked a pull request Feb 4, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant