-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valet commands hang and don't continue with v3 upgrade #1224
Comments
@NasirNobin do you have any thoughts here? |
@driesvints can you check (maybe the second monitor if you have) and see if there's any password prompt? (Can't think of another reason for this behavior at the moment) |
There's no password prompt. |
I tried downgrading to Valet v2 but the same issues persist. I didn't had these issues before upgrading to Valet v3 🤔 |
I added a bunch of
The command that is hanging is:
I ran the same command manually and it still hangs (see the screenshot above), so it isn't necessarily being caused by Valet. I'm not sure if it has something to do with how it's being called by Valet, however. |
To help track what is happening, here is the pertinent output that I added to the install process:
|
To get back to where I can actually use my local environment, I had to:
Your local sites will not be secured, so you'll need to remember to use |
There's definitely something wonky going on here, and it might be a macOS issue, given that the problem seems to lie with the auth prompt for What version of macOS are you guys on by the way? (Might be a recent issue, hence why you maybe didn't encounter this before...) |
Monterey 12.3 |
I couldn't reproduce this on my MBP 2020 M1 & 2021 M1 Pro models both running 12.3. @driesvints what's the model/year of your MacBook? |
I just tried running I did get multiple Touch ID prompts, one for every domain. I also spotted a |
MacBook Pro M1 Max from 2021. |
I'm running Monterey 12.3 on a MacBook Pro (16-inch, 2019). After a reboot (I'm assuming because it clears auth) I get Touch ID prompts for the first few certs, and then it hangs. If I kill the install process and run it again, it hangs on the first one. |
Can anyone try this and confirm if this solves anything?
For me, it does get rid of the prompt. Then again enables the prompt. Snippet taken from #1135 |
also, anyone having this issue please share the output of this command, it might help us track down the underlying issue. security authorizationdb read com.apple.trust-settings.admin |
@NasirNobin - Your steps above worked for me. I had it where it was stuck asking for a password constantly before running them. If it will help, when I run your command I get the following (Please note this is after getting V3 installed):
|
@NasirNobin here is my output:
|
@NasirNobin running those commands doesn't fix the issue for me. It still gets stuck on the |
Had the same thing. For what it's worth adding my experience: Tried the commands in #1224 (comment). Still got stuck on valet install. Did a restart. Install worked. |
Unfortunately, it still hangs on the "Installing nginx directory..." step.
|
Can anyone who has this issue try rebooting their Mac and try again? |
Just to be clear, what I did was first run the set of commands up until My thinking was something with auth tied to the user that would clear/flush on restart (probably logout too?). Or that was just a big coincidence... :) |
It finally worked for me after a restart. It's odd because I tried that before and it didn't work before. Anyway, thanks all to help debug this one! :) |
@driesvints Just curious, did you authenticate using fingerprint when it got stuck? Just did this upgrade on another machine and opted for typing the password, and except for all the prompts in #1226, that worked. While mine with the fingerprint got stuck. |
I indeed used fingerprint. |
@ErikBernskiold Like Dries, I had the same issue — and eventually figured out the only way past it was by not using TouchID, as I described in #1226. Keychain Access would also become completely unresponsive. |
I had the same symptoms and I was using Touch ID. For me, the resolution was to open up System Preferences and open the "Apple ID" panel. There was a warning about Apple ID needing to sign-in. Once I cleared this warning Valet started working again. |
Description:
When I try to run
valet install
, the commands hangs and stops at "Installing nginx directory...". When I runvalet secure
on a site, the command also hangs and stops.This started to happen with the v3 upgrade. I have no idea what's going on...
Steps To Reproduce:
Run either
valet secure
orvalet install
.Diagnosis
sw_vers
valet --version
cat ~/.config/valet/config.json
cat ~/.composer/composer.json
composer global diagnose
composer global outdated
ls -al /etc/sudoers.d/
brew config
brew services list
brew list --formula --versions | grep -E "(php|nginx|dnsmasq|mariadb|mysql|mailhog|openssl)(@\d\..*)?\s"
brew outdated
brew tap
php -v
which -a php
php --ini
nginx -v
curl --version
php --ri curl
~/.composer/vendor/laravel/valet/bin/ngrok version
~/.composer/vendor/laravel/valet/bin/ngrok-arm version
ls -al ~/.ngrok2
brew info nginx
brew info php
brew info openssl
openssl version -a
openssl ciphers
sudo nginx -t
which -a php-fpm
/opt/homebrew/opt/php/sbin/php-fpm -v
sudo /opt/homebrew/opt/php/sbin/php-fpm -y /opt/homebrew/etc/php/8.1/php-fpm.conf --test
ls -al ~/Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchDaemons | grep homebrew
ls -al /Library/LaunchDaemons | grep "com.laravel.valet."
ls -aln /etc/resolv.conf
cat /etc/resolv.conf
ifconfig lo0
sh -c 'echo "------\n/opt/homebrew/etc/nginx/valet/valet.conf\n---\n"; cat /opt/homebrew/etc/nginx/valet/valet.conf | grep -n "# valet loopback"; echo "\n------\n"'
sh -c 'for file in ~/.config/valet/dnsmasq.d/*; do echo "------\n~/.config/valet/dnsmasq.d/$(basename $file)\n---\n"; cat $file; echo "\n------\n"; done'
sh -c 'for file in ~/.config/valet/nginx/*; do echo "------\n~/.config/valet/nginx/$(basename $file)\n---\n"; cat $file | grep -n "# valet loopback"; echo "\n------\n"; done'
The text was updated successfully, but these errors were encountered: