-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process results supposes the "Averages" row is always at the same index #937
Comments
Hello @miguelriemoliveira. atom/atom_batch_execution/scripts/process_results Lines 25 to 46 in f147c0e
I have removed all non-Average rows from the df, so a simple average would suffice, no need to group. |
Well the assumption is that we will have one row where the first columns says "Averages", right? I think we can go with that, mut it should perhaps be written in the code of the scripts producing these tables that this is the convention. |
I agree, I think this is okay like this. Alternatively (though it sounds a bit "janky"), we could have an optional argument to change the "average row name"? That way it still works if the |
I like this idea from @Kazadhum . |
Hello @miguelriemoliveira and @Kazadhum. |
Sure. Thanks. |
Yes, thank you! |
Process results now, as is, assumes the averages row is at the same index in every evaluation, which might not be that case.
This is done in this function:
atom/atom_batch_execution/scripts/process_results
Lines 25 to 43 in 9214691
The text was updated successfully, but these errors were encountered: