Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkVersion #391

Closed
ktnishide opened this issue Mar 8, 2024 · 4 comments
Closed

checkVersion #391

ktnishide opened this issue Mar 8, 2024 · 4 comments
Labels
How To? This is a how to question

Comments

@ktnishide
Copy link

ktnishide commented Mar 8, 2024

Upgrader checkVersion is removed? what is the alternative?

Upgrader version 9.0.0

thanks

@larryaasen
Copy link
Owner

I see checkVersion right here:

void checkVersion({required BuildContext context}) {

@larryaasen larryaasen added the How To? This is a how to question label Mar 19, 2024
@ktnishide
Copy link
Author

Sorry, let me clarify.

We were using upgrader.checkVersion() to programmatically check and display alert when app return to foreground on Upgrader version 6.5.0 but now we realized the package implemented the feature.

Sorry for the misunderstanding.

@vladchuk
Copy link

vladchuk commented May 28, 2024

I am still not quite clear on how to check version at will: checkVersion() is no longer on the Upgrader, but on AlertDialog state. What if I can't/don't want to inject the alert into my widget hierarchy?..

Unless I'm missing something, it looks like useful functionality was removed. Can you please explain?

@vladchuk
Copy link

vladchuk commented May 29, 2024

I ended up bastardizing UpgradeAlert as follows:

  • make UpgradeAlert a plain class (not a widget)
  • conflate UpgradeAlertState with it, exposing checkVersion(), etc.
  • instantiate alert right after upgrader and use it as before (in v. 8.x.x)

All in all, this feels like a regression. Please consider bringing the original functionality back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
How To? This is a how to question
Projects
None yet
Development

No branches or pull requests

3 participants