Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the ESPAsyncHTTPClient library #1

Open
larsensolutions opened this issue Dec 5, 2018 · 0 comments
Open

Refactor the ESPAsyncHTTPClient library #1

larsensolutions opened this issue Dec 5, 2018 · 0 comments

Comments

@larsensolutions
Copy link
Owner

Added the ESPAsyncHttpClient library so I could have async API calls.

  • Reason: Using the common HttpClient is blocking the main loop, so whenever a http request went out and a button was pushed while waiting for the response, the button click was not registered. This led to a poor experience really.

However, the ESPAsyncHttpClient is old and buggy and should be refactored. For now I have made changes (like closing connecting when response is received (ref line 113: self->aClient->close(true); ):

  1. Split into methods, the logic finding protocol, port, host etc from the full URL is not working.
  2. Remove the #if and https lines. Don't need that and it is not tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant