Add aria-label to drop-down currency fields

[OldNGreyBMR]

For improved WCAG compliance I added an aria-label to the currency field drop down.

includes\classes\observers\ZcaBootstrapObserver.php line 197 was

        case 'NOTIFY_ZEN_DRAW_PULL_DOWN_MENU':
            $field = $p2;
            if (strpos($field, 'class="') !== false) {
                $field = str_replace('class="', 'class="custom-select', $field);
            } else {
                $field = str_replace('<select ', '<select class="custom-select" ', $field);
            }
            $p2 = $field;
            break;

---

changed to

 case 'NOTIFY_ZEN_DRAW_PULL_DOWN_MENU':
            $field = $p2;
            $arialabel = 'aria-label="'.$p1["name"] .'"'; 
            if (strpos($field, 'class="') !== false) {
                $arialabel2 = ' class="custom-select' . $arialabel ;
                $field = str_replace('class="', $arialabel2, $field);
            } else {
                $arialabel3 =  '<select class="custom-select" ' .$arialabel; 
                $field = str_replace('<select ', $arialabel3, $field);
            }
            $p2 = $field;
            break;

---

[lat9]

Hmm, that simply adds an aria-label="{name of the dropdown}", not a real name. Shouldn't the dropdown(s) be preceded by a <label>, possibly with a sr-only class so that they're not displayed in non-reader mode?

[OldNGreyBMR]

Now that I am aware of the sr-only class you are correct. My bodge was a response to the Accessibility Report ratings from tools like LightHouse, accessibleweb and a11y and the information they referenced. Bailey

…

On Mon, 4 Apr 2022 at 03:28, lat9 ***@***.***> wrote: Hmm, that simply adds an aria-label="{name of the dropdown}", not a real name. Shouldn't the dropdown(s) be preceded by a <label>, possibly with a sr-only class so that they're not displayed in non-reader mode? — Reply to this email directly, view it on GitHub <#115 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARNJ2NID2ZFBPEXXYSIR3LLVDHIKPANCNFSM5SHNXQ3Q> . You are receiving this because you authored the thread.Message ID: ***@***.***>