Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cart table layout #287

Open
torvista opened this issue Oct 26, 2023 · 2 comments
Open

cart table layout #287

torvista opened this issue Oct 26, 2023 · 2 comments

Comments

@torvista
Copy link

Just for discussion/comments....

BS4:
cart_bs4

Mine:
cart mv

I feel its more logical to have the columns as unit quantity x quantity = subtotal.

Also the text of "Total" for the column seems to me incorrect: should be a subtotal, and the final sum should be "Total", not "Subtotal", so reversed.

@lat9
Copy link
Owner

lat9 commented Oct 26, 2023

Good points, @torvista. I'll note, however, that the "Total" vs. "Sub-Total" depends on whether (like you) or not (like me) a site displays their prices with tax included.

What does your layout look like in phone/portrait and phone/landscape mode?

@torvista
Copy link
Author

portrait
image

landscape
image

Model is nowrap. For general use the array would need to be checked for the existence of a model in one of the elements to determine if the column should be displayed at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants