Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promises, promises #10

Open
ekkis opened this issue May 2, 2022 · 1 comment
Open

Promises, promises #10

ekkis opened this issue May 2, 2022 · 1 comment

Comments

@ekkis
Copy link
Collaborator

ekkis commented May 2, 2022

the request module in use by this package was deprecated a long time ago and doesn't support promises. I want to give this package the ability to use both callbacks (for backward compatibility) and promises, which are more modern and easier to use. I've therefore swapped request for node-fetch but I'm running into an issue. perhaps you could help? it's not properly germane to this package but if I can get it solved I can modernise this package. I've posted the issue here: mhart/aws4#144
@ekkis ekkis changed the title Promises Promises, promises May 2, 2022
@ekkis
Copy link
Collaborator Author

ekkis commented May 3, 2022

ok. I've solved the issue. the changes have been added to the open PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ekkis