Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing attributes to compile with GCC 4.8 #97

Closed
Gregwar opened this issue Oct 29, 2014 · 3 comments
Closed

Fixing attributes to compile with GCC 4.8 #97

Gregwar opened this issue Oct 29, 2014 · 3 comments

Comments

@Gregwar
Copy link
Contributor

Gregwar commented Oct 29, 2014

The correct toolchain is now available in debian sid/testing:
https://packages.debian.org/jessie/gcc-arm-none-eabi
https://packages.debian.org/jessie/libstdc++-arm-none-eabi-newlib

I've successfully compiled LibMaple with that. However, there is two errors here:
https://github.com/leaflabs/libmaple/blob/master/libmaple/include/libmaple/libmaple_types.h#L58

First, __unused is already defined, a testing it with ifndef is enough to fix that

The __always_inline is also defined, but it doesn't automatically adds the inline keyword. So, I propose changing all the occurences of __always_inline in the lib maple to inline __always_inline and also adding an ifndef

I can do a PR for that

@Gregwar
Copy link
Contributor Author

Gregwar commented Oct 29, 2014

See:
RobotsWar/RobotsWar@af4d4ba

@mbolivar
Copy link
Contributor

Fixed, thanks; please reopen if you run into trouble.

@mbolivar
Copy link
Contributor

(I think the extra "inline" with __always_inline is redundant: https://gcc.gnu.org/ml/gcc-help/2007-01/msg00051.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants