Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go over suggestions in #51 #58

Open
urkud opened this issue Feb 29, 2024 · 2 comments
Open

Go over suggestions in #51 #58

urkud opened this issue Feb 29, 2024 · 2 comments

Comments

@urkud
Copy link
Member

urkud commented Feb 29, 2024

In #51, @akirak made some suggestions that were deemed out of the scope of that PR. Go over these suggestions and decide whether to implement them.

@bustercopley
Copy link
Contributor

bustercopley commented Feb 29, 2024

First change (in lean4-lake-find-dir in "lean4-lake.el"):

I agree with the change but I also wonder if anyone would notice if we deleted "lean4-lake.el". We could just mention in the README that building happens automatically when lake is started as a server, and direct users to the compile command if they do need to run lake build.

Second change (in lean4-find-files in "lean4-util.el"):

lean4-find-files and lean4--collect-entries are unused and should be deleted.

Third change (in lean4-get-executable in "lean4-util.el"):

The change depends on Emacs 28.1, but I think it's worth supporting 27.1 a while longer unless we have a more compelling reason. If I'm reading the docs right, 27.1 is the default on Debian oldstable (bullseye) and Ubuntu 22.04.

@phikal
Copy link
Contributor

phikal commented Mar 7, 2024

The change depends on Emacs 28.1, but I think it's worth supporting 27.1 a while longer unless we have a more compelling reason. If I'm reading the docs right, 27.1 is the default on Debian oldstable (bullseye) and Ubuntu 22.04.

FWIW you could use Compat to help out here, since the library provides a backwards compatible definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants