Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of contents still picking up English headings. #133

Closed
niruvt opened this issue Feb 13, 2021 · 3 comments
Closed

Table of contents still picking up English headings. #133

niruvt opened this issue Feb 13, 2021 · 3 comments

Comments

@niruvt
Copy link
Contributor

niruvt commented Feb 13, 2021

This issue is related to this comment. Table of contents on my fork is for some reasons picking up English headings. See: https://niranjantambe.github.io/learnlatex.github.io/mr/#1-latex-basics (Though not always. See: https://niranjantambe.github.io/learnlatex.github.io/mr/#लाटेक्-आज्ञावल्यांचे-प्रदर्शन)

I checked the code for lesson-01 and extra-01 (which are the two files linked above) again and again, but found no significant difference in them. Can somebody please guide me?

@davidcarlisle
Copy link
Member

The toc wording comes from each page in the top yml section eg lesson-01 has

toc-anchor-text: "LaTeX basics"
toc-description: "What LaTeX is and how it works."

You have translated that but I see it's not pulling the translated text in the table of contents.

If you look under settings on your at the github pages section do you see an error or is it building OK?

I can't see any error looking at the web view of your sources. I may fork your fork and clone it here later so I can see. I can't see anything wrong currently

@davidcarlisle
Copy link
Member

@NiranjanTambe found it..

in https://raw.githubusercontent.com/NiranjanTambe/learnlatex.github.io/master/mr/index.md

You still have

{% include toc-lessons.html prefix="en/lesson" %}

with en prefix, the extra and language-specific sections have been changed to mr which is why extra-01 works correctly

<h2 class="heading__toc">संकीर्ण प्रकरणे</h2>
<ul class="lessons-toc">
  {% include toc-additional-lessons.html prefix="mr/language" %}
  {% include toc-additional-lessons.html prefix="mr/extra" %}
</ul>

@niruvt
Copy link
Contributor Author

niruvt commented Feb 14, 2021

Thanks :)

This solved the problem. Apologies for the mistake.

niruvt@24d13e1

@niruvt niruvt closed this as completed Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants