Skip to content

Latest commit

 

History

History
26 lines (18 loc) · 690 Bytes

pull_request_template.md

File metadata and controls

26 lines (18 loc) · 690 Bytes

Checklist

Definition Of Review

  • Own code review done (add notes for others)
  • Write message in teams channel
     <Title>
    
    *️⃣ Impacted projects : Core - DataStudio - Admin - @leav/ui - @leav/utils - ...
    
    📖 Ticket: https://aristid.atlassian.net/browse/<JIRA_TICKET_IDENTIFIER>
    
    🧑‍💻 PR: <link to PR/MR>
    
    ℹ Info: <brief explanation - context - how to test>
    

Definition Of Mergeable

  • 2 approves
  • 1 functional review - US has been tested
  • Every comment is handled - blocking ones have been resolved by reviewer
  • Design OK
  • Can be tested by POs
  • PR was introduced during daily meeting