Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code from documentation fails due to null values #1006

Open
vi opened this issue Oct 8, 2024 · 1 comment
Open

Code from documentation fails due to null values #1006

vi opened this issue Oct 8, 2024 · 1 comment

Comments

@vi
Copy link

vi commented Oct 8, 2024

The documentation contains this line in a code snippet:

value: (self, rawValue) => "$" + rawValue.toFixed(2),

But the library calls it with a null rawValue, leading to errors in console.

@leeoniya
Copy link
Owner

leeoniya commented Oct 9, 2024

ah, yeah. this changed a couple years ago. when there is cursor "un-hover", these functions get called with null to allow custom-setting the legend. see #644.

all the demos which use the value or values options are updated to handle null, e.g. https://leeoniya.github.io/uPlot/demos/area-fill.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants